Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keyName column may not be present in pagination cursor #41

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: keyName column may not be present in pagination cursor #41

merged 2 commits into from
Oct 31, 2024

Conversation

haddowg
Copy link
Contributor

@haddowg haddowg commented Oct 29, 2024

The laravel cursor parameter function throws an exception if the requested key is not present in the cursors' parameters.
However, when using withoutKeySort() on your CursorPaginator the key will not be there and we should ignore its absence.

@lindyhopchris
Copy link
Contributor

Thanks for the PR. Any chance of a test that recreates the scenario?

@lindyhopchris lindyhopchris self-requested a review October 31, 2024 10:42
@haddowg
Copy link
Contributor Author

haddowg commented Oct 31, 2024

Thanks for the PR. Any chance of a test that recreates the scenario?

done

@lindyhopchris lindyhopchris merged commit 30f153f into laravel-json-api:develop Oct 31, 2024
2 checks passed
@lindyhopchris
Copy link
Contributor

Thanks! Released in 4.3.1.

@haddowg haddowg deleted the fix/cursor-parser branch December 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindyhopchris lindyhopchris Awaiting requested review from lindyhopchris

Assignees
No one assigned
Labels
None yet
Projects
Big Board of Everything
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haddowg @lindyhopchris