Enable reading of filter configuration publicly #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindyhopchris
requested changes
Jul 28, 2021
… and asking column and operator configuration.
bbrala
force-pushed
the
feature/public-filter-methods
branch
from
741ef1e to
8d34036
Compare
|
I've pushed a commit excluding the changed to |
|
Thanks! I'm going to be working on this package this weekend, so will merge then. |
lindyhopchris
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor filters to some traits enable checking for implemented trait and asking column and operator configuration.
Reason i used traits is so we can check if a trait is implemented with Laravel method class_uses_recursive.
Fixes #17