Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple URL params #10

Open
weierophinney opened this issue Dec 31, 2019 · 0 comments
Open

Add support for multiple URL params #10

weierophinney opened this issue Dec 31, 2019 · 0 comments

Comments

@weierophinney
Copy link
Contributor

Currently, only optional params are exposed when looking at a service.

Example:

screen shot 2016-02-16 at 11 44 48 am

It'd be awesome to add support for non-optional params

Example:

screen shot 2016-02-16 at 11 43 59 am

In Service.php, in the toArray() method, this is happening:

$routeWithReplacements = str_replace(['[', ']', '{/', '{:'], ['{', '}', '/{', '{'], $service->route);

Changing it to:

$routeWithReplacements = preg_replace('#\[?\/:(\w+)\]?#', '/{$1}', $service->route);

will give the results I'd like to see.

If this change is acceptable, I can go ahead and make a PR, otherwise, I'm open to hearing other ideas to add support for this.


Originally posted by @stringerbell at zfcampus/zf-apigility-documentation-swagger#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant