Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZF\Configuration\ConfigWriter replacement is inconvenient #5

Closed
weierophinney opened this issue Dec 31, 2019 · 2 comments
Closed

ZF\Configuration\ConfigWriter replacement is inconvenient #5

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Contributor

Is there a reason, why ZF\Configuration uses Zend\Config\Writer\WriterInterface (good) for extensibility, but provides this service via Zend\ModuleManager\Feature\ServiceProviderInterface API (bad) and not simply via module configuration?

This makes overriding with another Zend\Config\Writer\WriterInterface-implementation less convenient. You have to either allow overriding (bad, affects everything in service manager) or hook up to certain events to make modification.


Originally posted by @akomm at zfcampus/zf-configuration#16

@weierophinney
Copy link
Contributor Author

The answer: It was overlooked.

Please feel free to submit a pull request that changes the behavior.


Originally posted by @weierophinney at zfcampus/zf-configuration#16 (comment)

@Xerkus
Copy link
Member

Xerkus commented Apr 13, 2023

This was fixed by 1.2.0 in 2016 but issue was left dangling and eventually migrated here.

@Xerkus Xerkus closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants