This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Sandboxed Fallback #1215
Open
fborello-lambda
wants to merge
15
commits into
sandboxed_native
Choose a base branch
from
sandboxed_fallback
base: sandboxed_native
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sandboxed Fallback #1215
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 19b7323 - Browse repository at this point
Copy the full SHA 19b7323View commit details -
Configuration menu - View commit details
-
Copy full SHA for b62af5d - Browse repository at this point
Copy the full SHA b62af5dView commit details
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad260af - Browse repository at this point
Copy the full SHA ad260afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76a0a08 - Browse repository at this point
Copy the full SHA 76a0a08View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0fa98eb - Browse repository at this point
Copy the full SHA 0fa98ebView commit details -
Gaston authored and Gaston committed
Jan 31, 2024 Configuration menu - View commit details
-
Copy full SHA for bb2bb28 - Browse repository at this point
Copy the full SHA bb2bb28View commit details -
Gaston authored and Gaston committed
Jan 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 45045b5 - Browse repository at this point
Copy the full SHA 45045b5View commit details
Commits on Feb 1, 2024
-
Change test from invoke_function to execution_entry_point
Gaston committedFeb 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 120ea44 - Browse repository at this point
Copy the full SHA 120ea44View commit details -
Test fallback procedure killing sandbox
Gaston committedFeb 1, 2024 Configuration menu - View commit details
-
Copy full SHA for be7da9f - Browse repository at this point
Copy the full SHA be7da9fView commit details
Commits on Feb 2, 2024
-
Add test for Fallback Mechanism
The test proposed kills `sandbox.proc` == `std::process:Child`. This kill makes the `sandbox` instance unusable. The current testbench checks with `lsof` command, using the `sandbox.proc`'s pid, comparing the outputs, before `sandbox.kill()` and after. A better way to test may be adding an extra field to the `ExecutionResult` struct: ```rust pub struct ExecutionResult { pub call_info: Option<CallInfo>, pub revert_error: Option<String>, pub native_or_casm: Option<String>, // <- For example pub n_reverted_steps: usize, } ``` in order to return some info related to the environment used to run the contract whenever `execution_entry_point.rs::execute()` is used.
Configuration menu - View commit details
-
Copy full SHA for 0a48f30 - Browse repository at this point
Copy the full SHA 0a48f30View commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f87da38 - Browse repository at this point
Copy the full SHA f87da38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07dd6cc - Browse repository at this point
Copy the full SHA 07dd6ccView commit details
Commits on Feb 6, 2024
-
Merge branch 'sandboxed_native' into sandboxed_fallback
Update branch
Configuration menu - View commit details
-
Copy full SHA for 4f4eda4 - Browse repository at this point
Copy the full SHA 4f4eda4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c300e3 - Browse repository at this point
Copy the full SHA 4c300e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 416f8b6 - Browse repository at this point
Copy the full SHA 416f8b6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.