-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state dump to compare Native and VM #58
Conversation
4a9a10d
to
409bac8
Compare
47e0162
to
f3f511a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very nice overall!
Maybe the only thing it would be nice check is that right now the state_dumps
folder is created relative to the path where the command was performed. Is it possible to have an absolute path? if not, there will be a new states-dump
folder every time the command is run somewhere where there's not such folder.
Perhaps it's just me, but I can run the command being in the states-dump
folder and have the mentioned result.
There might be a way to have it set to an absolute path relative to the repository (by traversing the directory structure until you find a |
This PR adds a new feature
state_dump
that dumps transaction execution info to a file, so that we can compare Native with VM for correctness.It also adds scripts for analyzing the dumped information.