Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state dump to compare Native and VM #58

Merged
merged 34 commits into from
Oct 2, 2024
Merged

Add state dump to compare Native and VM #58

merged 34 commits into from
Oct 2, 2024

Conversation

JulianGCalderon
Copy link
Contributor

This PR adds a new feature state_dump that dumps transaction execution info to a file, so that we can compare Native with VM for correctness.

It also adds scripts for analyzing the dumped information.

@JulianGCalderon JulianGCalderon changed the base branch from main to update-llvm19 September 25, 2024 14:10
@JulianGCalderon JulianGCalderon changed the title Add state dump to compare Native and VM thoroughly Add state dump to compare Native and V Sep 26, 2024
@JulianGCalderon JulianGCalderon changed the title Add state dump to compare Native and V Add state dump to compare Native and VM Sep 26, 2024
@JulianGCalderon JulianGCalderon changed the base branch from update-llvm19 to main September 26, 2024 20:12
@JulianGCalderon JulianGCalderon changed the base branch from main to contract_executor September 26, 2024 20:15
@JulianGCalderon JulianGCalderon changed the base branch from contract_executor to main October 1, 2024 18:14
@JulianGCalderon JulianGCalderon marked this pull request as ready for review October 1, 2024 18:17
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very nice overall!

Maybe the only thing it would be nice check is that right now the state_dumps folder is created relative to the path where the command was performed. Is it possible to have an absolute path? if not, there will be a new states-dump folder every time the command is run somewhere where there's not such folder.
Perhaps it's just me, but I can run the command being in the states-dump folder and have the mentioned result.

@JulianGCalderon
Copy link
Contributor Author

JulianGCalderon commented Oct 1, 2024

There might be a way to have it set to an absolute path relative to the repository (by traversing the directory structure until you find a Cargo.toml, for example), but I don't see a reason to do it. By doing that, you eliminate the possibility to compile the binary and run it elsewhere. I think the current behavior is more intuitive.

@pefontana pefontana added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit d4c4ecf Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants