Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yas swap benchmarks #22

Open
pefontana opened this issue Jul 5, 2024 · 1 comment
Open

Add Yas swap benchmarks #22

pefontana opened this issue Jul 5, 2024 · 1 comment
Assignees

Comments

@pefontana
Copy link
Collaborator

The idea is to benchmark the Yas swap execution using criterion, like we did in starknet_in_rust crate https://github.com/lambdaclass/starknet_in_rust/blob/99c7b3b29a78cf8a27cc61bcdc029ed4255817ad/bench/yas.rs
For what I know, there are two options to replicate this benchmarks:

  • The way we do it in Starknet in rust:
    Create the transactions in rust, deploying the account and the yas contract and making an invoke tx to execute the swap
  • Get an invoke tx that invoke the yas contract and execute it
    We need to evaluate what option is better and implement it

Note. The idea of the benchmark is to execute the swap many times, so we can have a better benchmarks

@FrancoGiachetta
Copy link
Contributor

I think we should we close this issue since it's already done en the blockifier. Though we should probably port it to the sequencer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants