Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-917] - Deathmatch mode #980

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[GH-917] - Deathmatch mode #980

wants to merge 19 commits into from

Conversation

tvillegas98
Copy link
Contributor

@tvillegas98 tvillegas98 commented Nov 8, 2024 •
edited
Loading

Warning

Merge alongside https://github.com/lambdaclass/champions_of_mirra/pull/2230

Motivation

Add a new game mode based on the deathmatch concept. All against all mode where the player with most kills wins the match.

Closes #917

Summary of changes

  • Added a new matchmaking for deathmatch mode
  • Added a respawn feature only enabled for deathmatch mode
  • Added a new win condition only enabled for deathmatch mode
  • Send the gamemode to the client

How to test it?

  • Open the browser client and play a game in the deathmatch mode. If you want, you can print the winner in apps/arena/lib/arena/game_updater.ex:337 and check that it is correct

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

tvillegas98
tvillegas98 commented Nov 8, 2024
View reviewed changes
apps/arena/lib/arena/matchmaking/deathmatch_mode.ex
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a matchmaking file for each game mode

@tvillegas98 tvillegas98 marked this pull request as ready for review November 8, 2024 21:32
@tvillegas98 tvillegas98 marked this pull request as draft November 8, 2024 21:33
@tvillegas98 tvillegas98 marked this pull request as ready for review November 8, 2024 21:38
Nico-Sanchez
Nico-Sanchez requested changes Nov 12, 2024
View reviewed changes
apps/arena/lib/arena/game/player.ex Outdated Show resolved Hide resolved
apps/arena/lib/arena/game_updater.ex Outdated Show resolved Hide resolved
apps/arena/lib/arena/game_updater.ex Outdated Show resolved Hide resolved
apps/arena/lib/arena/matchmaking/deathmatch_mode.ex Outdated Show resolved Hide resolved
apps/serialization/messages.proto Show resolved Hide resolved
@tvillegas98
Copy link
Contributor Author

all changes were done in chore: requested changes

Nico-Sanchez
Nico-Sanchez previously approved these changes Nov 13, 2024
View reviewed changes
Nico-Sanchez
Nico-Sanchez previously approved these changes Nov 15, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nico-Sanchez Nico-Sanchez Nico-Sanchez approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create Deathmatch gamemode
2 participants
@tvillegas98 @Nico-Sanchez