Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initiate RLPx connections from discv4 #837

Closed
Tracked by #19
ElFantasma opened this issue Oct 14, 2024 · 0 comments · Fixed by #936
Closed
Tracked by #19

Initiate RLPx connections from discv4 #837

ElFantasma opened this issue Oct 14, 2024 · 0 comments · Fixed by #936
Assignees
@ElFantasma
Labels
network Issues related to network communication
Milestone
[L1] 4 - P2P Network

Comments

@ElFantasma
Copy link
Contributor

ElFantasma commented Oct 14, 2024 •
edited
Loading

Currently discv4 handles the peer discovery, and it has to delegate the RLPx connection to a new task.

See this TODO and remove this harcoded test and it's related function
@ElFantasma ElFantasma mentioned this issue Oct 14, 2024
Open
16 tasks
@ElFantasma ElFantasma added the network Issues related to network communication label Oct 14, 2024
@ElFantasma ElFantasma added this to the 4 - P2P Network milestone Oct 14, 2024
@ElFantasma ElFantasma self-assigned this Oct 16, 2024
@ElFantasma ElFantasma linked a pull request Oct 22, 2024 that will close this issue
feat(l1): initiate rlpx connections from discv4 #936
Merged
@ElFantasma ElFantasma mentioned this issue Oct 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 23, 2024
@ElFantasma @maximopalopoli
@jrchatruc @fborello-lambda @MarcosNicolau @rodrigo-o @ilitteri @ManuelBilbao @mpaulucci @gsbujo
feat(l1): initiate rlpx connections from discv4 (#936)
943a395 
**Motivation**

DiscV4 protocol discovers new peers, and after deciding it is a valid
peer, a TCP connection is established and RLPx protocol starts

**Description**

Now, when receiving a DiscV4 Pong message and after evaluating the peer,
a RLPx connection is created and established. If handshake fails it
removes the peer from the Kademlia table.

Closes #837.

Also removed some hard-coded testing code.

Once the listen loop is built (#840) there may be other conditions where
a peer has to be discarded. (eg. when the other peer sends a Disconnect
message). After #840 is completed we may create some more issues on this
regard.

---------

Co-authored-by: Maximo Palopoli <[email protected]>
Co-authored-by: Javier Rodríguez Chatruc <[email protected]>
Co-authored-by: Federico Borello <[email protected]>
Co-authored-by: Marcos Nicolau <[email protected]>
Co-authored-by: Rodrigo Oliveri <[email protected]>
Co-authored-by: Ivan Litteri <[email protected]>
Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
Co-authored-by: Martin Paulucci <[email protected]>
Co-authored-by: François <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElFantasma ElFantasma

Labels
network Issues related to network communication
Projects
ethrex_l1
Status: Done
Milestone
[L1] 4 - P2P Network
Development

Successfully merging a pull request may close this issue.

feat(l1): initiate rlpx connections from discv4 lambdaclass/ethrex
1 participant
@ElFantasma