Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(L2): add uniqueness to deposit logs on L1 #1191

Open
Tracked by #1279
ManuelBilbao opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1321
Open
Tracked by #1279

fix(L2): add uniqueness to deposit logs on L1 #1191

ManuelBilbao opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1321
Labels
L2

Comments

@ManuelBilbao
Copy link
Contributor

Currently when someone makes a deposit the result of keccak(to || value) is saved in the depositLogs list of the L1 bridge contract. As we will use this to check repeated transacitions, they should be unique.

Note: the nonce isn't a great choice for uniqueness since the deposit beneficiary can be different than the sender
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L2
Projects
ethrex_l1
Status: No status
ethrex_l2
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(l2): l1_watcher make deposits unique lambdaclass/ethrex
1 participant
@ManuelBilbao