Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ast refactor #140

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Ast refactor #140

merged 7 commits into from
Jun 7, 2024

Conversation

kenarab
Copy link
Collaborator

@kenarab kenarab commented May 31, 2024

It has a dependency on PR #139.

It includes renaming structs for having a better convention for understanding code.

Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@kenarab
Copy link
Collaborator Author

kenarab commented Jun 3, 2024

See comments

Applied all suggestions. There is still an open question to a comment

@kenarab
Copy link
Collaborator Author

kenarab commented Jun 3, 2024

See comments

Applied all suggestions. There is still an open question to a comment

All reviewed changes closed

@igaray igaray merged commit 9575fbe into lambdaclass:main Jun 7, 2024
5 of 6 checks passed
@kenarab kenarab deleted the ast-refactor branch June 7, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants