Admin crud #44
Admin crud #44
Conversation
Apply fixes from StyleCI
Apply fixes from StyleCI
Apply fixes from StyleCI
Apply fixes from StyleCI
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| // UI settings | ||
| // | ||
| //============================================================================== | ||
|
|
There was a problem hiding this comment.
Codacy has a fix for the issue: Delete ␍
| { | ||
| var SoundPlayer = app.SoundPlayer = function() | ||
| { | ||
| // Dummy interface |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace ········//·Dummy·interface␍ with ····//·Dummy·interface
| // Dummy interface | |
| // Dummy interface |
| * @author davidshimjs | ||
| * @see <a href="http://www.d-project.com/" target="_blank">http://www.d-project.com/</a> | ||
| * @see <a href="http://jeromeetienne.github.com/jquery-qrcode/" target="_blank">http://jeromeetienne.github.com/jquery-qrcode/</a> | ||
| */ |
There was a problem hiding this comment.
Codacy has a fix for the issue: Delete ␍
| */ | |
| */ |
| switch(notify.permissionLevel()) | ||
| { | ||
| case notify.PERMISSION_DENIED: | ||
| // Do nothing |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace ····················//·Do·nothing␍ with ··········//·Do·nothing
| // Do nothing | |
| // Do nothing |
|
|
||
| onready : function() | ||
| { | ||
| // Expose functional interface |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace ················//·Expose·functional·interface␍ with ········//·Expose·functional·interface
| // Expose functional interface | |
| // Expose functional interface |
| @@ -0,0 +1,735 @@ | |||
| //============================================================================== | |||
| // | |||
There was a problem hiding this comment.
Codacy has a fix for the issue: Delete ␍
| // | |
| // |
|
|
||
| // System settings | ||
|
|
||
| autoShow : true |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace ············autoShow·:·true␍ with ······autoShow:·true,
| autoShow : true | |
| autoShow: true, |
|
|
||
| element.innerHTML = ''; | ||
|
|
||
| new QRCode(element, { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace ············new·QRCode(element,·{␍ with ······new·QRCode(element,·{
| new QRCode(element, { | |
| new QRCode(element, { |
| { | ||
| var fromUser = attributes.from_user_info; | ||
|
|
||
| this.fromUser = fromUser; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace ····················this.fromUser·=·fromUser;␍ with ············this.fromUser·=·fromUser;
| this.fromUser = fromUser; | |
| this.fromUser = fromUser; |
meerasharma00
requested review from
ajaz-ul-haq,
saddamhmalik01 and
sandesh556
| { | ||
| try { | ||
| $user = User::find($id); | ||
| $user->delete(); |
There was a problem hiding this comment.
Are we using InnoDB as the engine? won't this cause an issue with the foreign keys
| public function showList() | ||
| { | ||
| try { | ||
| $data = Department::all(); |
There was a problem hiding this comment.
Won't this query cause an issue if i have a lot of data
| public function deleteDepartment($id) | ||
| { | ||
| try { | ||
| $department = Department::find($id); |
| public function envelope() | ||
| { | ||
| return new Envelope( | ||
| from: new Address('[email protected]', 'Meera'), |
| { | ||
| Schema::create('jobs', function (Blueprint $table) { | ||
| $table->bigIncrements('id'); | ||
| $table->string('queue')->index(); |
There was a problem hiding this comment.
indexing is done generally for foreign keys, Add it for any column would take up memory
| }); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Also if we are using InnoDB, indexing will be done automatically
|
Also, we don't have the option to upload logos? are we directly inserting it in storage or a public folder? |
Fixes #29