-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setuptools-scm to control version #125
base: main
Are you sure you want to change the base?
Conversation
The setup is producing |
But isn't the action checking out the current branch? |
The action is doing a shallow fetch by default, and does not pull tags/history. There is an option to load the history |
adfabca
to
89c1210
Compare
03ac88c
to
0e97642
Compare
MANIFEST.in
Outdated
@@ -9,6 +9,7 @@ prune tests | |||
prune .github | |||
prune .tox | |||
|
|||
exclude src/torchpme/_version.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure about this? I would think we need this file included in the sdist so we have the same version when building the wheels from the sdist as when building wheels from the git checkout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I was not. But I tried and the _version.py
is in the wheel and for the sdist it will be created again. So seems to be okay to have this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh you might be right with the sdist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an ignore for check-manifest
. This fixes the issue and we have a _version.py
in the sdist.
39359b1
to
26fce8c
Compare
version seems to be fine now. torch_pme-0.1.1.dev4%2Bgc83b853-0 |
84a0fb6
to
1242fcb
Compare
Use setuptools-scm to automatically create the version string based on git tag. For example for the current PR this would be
using these systems makes comparisons between developer version easier.
Contributor (creator of pull-request) checklist
Reviewer checklist
📚 Documentation preview 📚: https://torch-pme--125.org.readthedocs.build/en/125/