Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid/empty HTTPS private or certificate key causes web server to break #302

Open
ITAC85v2 opened this issue Mar 28, 2022 · 1 comment

Comments

@ITAC85v2
Copy link

ITAC85v2 commented Mar 28, 2022

Edit: I think I accidentally wrote a duplicate issue, not sure if I should close or not.

I stumbled upon this accidentally when I tried to enable HTTPS but forgot to generate the keys. I'm using Chrome OS, by the way, if that's helpful at all.

What happens is it at first shows URI as https://(ip):undefined/
image
Then upon restarting the web server, it refuses to start, even after restarting the app (the only way to fix it is to kill the app)
image

Here's the steps to reproduce:
-Start the web server
-Enable "Use https://"
-Set "Private key string" and "Certificate string" to empty or something invalid
(url should now show https://(ip):undefined, even after disabling https)
-Stop and start the web server
(the web server should now refuse to start and forever say "starting")

It's not a huge issue, but it did cause me a little bit of headache when I found it, trying to get the web server to work again.

@ethanaobrien
Copy link

#264 will fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants