Refactor Javascript

[crantron]

Rewrite using best practices.

[TheGuywithTheHat]

afaik kyro is working on refactoring right now.

[crantron]

So am I :)

[kyrofox]

Hi crantron, were you the same person that emailed me about refactoring? Because I think multiple people might be working on this.

[crantron]

no worries, I'm going to do it in a module fashion in a separate branch. That way you can merge code that doesnt conflict with others.

[kyrofox]

Hey! I just wanted to say thank you for taking the initiative on this. I'm working on my own refactor changes, and I'll merge both of these together. Once you have enough done, we should talk on discord to figure out how we'll combine everything.

[Willsr71]

Random question and I might be blind, but is there a discord invite link floating around somewhere?

[kyrofox]

https://discord.gg/0126CWWHr0DyiJYz6

[HoverBaum]

Rewiring code with best practices maybe there should first be a discussion about what practices should be used. Or else someone should be appointed to decide. The later may actually be more feasible for now. Just have someone decide what to use for now and work with that. Discussing what to use would take ages and we would probably stay more motivated by just hacking away.

[ghost]

Or else someone should be appointed to decide.

Who then? I do know about some good practices, but I'm still new to this.

[HoverBaum]

Who then? I do know about some good practices, but I'm still new to this.

Probably @kyrofox as the owner here. Since he put the most work in so far and is likely to stay on. While everyone else just jumped the wagon and no idea how long people will stay.

Or we could make a few proposals and put them to the vote. But again that takes time.

[ghost]

I think @kyrofox learned jQuery just recently, to be able to develop this extension. So he might not be yet aware of best practices.

[kyrofox]

I got the merging/code review part once you guys have things refactored, don't worry. If anything, I'll learn best practices out of what you guys give in the refactor. And yes, I did only begin trying to use jQuery seriously with this plugin, though I've used it and read it before; regardless, jQuery refactoring will need to be done. As for pure JS refactoring, I've got under control. I'm fixing the major issues, but we'll get back to that later. Please know that I coded some of these with a specific sub-optimal arch because I said "fuck readability, go for decent UX for now", so I could go fast, and just run a refactor pass and redo these later. Thanks guys for helping on the refactor, glhf!

[ghost]

Thing is, we still should decide on a standard to follow. Not only on best practices, but coding style too. Some references:

• W3C JavaScript Best Pratices
• jQuery Code Organization
• Google JavaScript Style Guide

[HoverBaum]

I think what we should do is write a guideline we want to follow. I will write up a document on how and why we should proceed and then people can add to it until we all agree on it.

[HoverBaum]

Wrote a first version of a proposal on who to organize files with a few general guidelines.
https://gist.github.com/HoverBaum/7f212b720799b23e19212ff0339741b7
Check it out and let me know what you think.

[ghost]

Seems pretty reasonable so far, I like it.