Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out event_study() and plot_event_study() #20

Open
grantmcdermott opened this issue Feb 2, 2023 · 3 comments
Open

Split out event_study() and plot_event_study() #20

grantmcdermott opened this issue Feb 2, 2023 · 3 comments

Comments

@grantmcdermott
Copy link
Collaborator

grantmcdermott commented Feb 2, 2023

Am I right in thinking that the majority of imports in the DESCRIPTION file are just there to cover possible backends in event_study()?

At any rate, I'm unable to install did2s because of a CMAKE dependency issue related to nloptr, which in turn is a recursive dependency of did. It's a long story, but I'm in a constrained cloud compute environment running CentOS 7, which ships some ancient system libraries. Dropping these extra dependencies would facilitate installation of the core did2s package without compromising the main estimation routine. (Please correct me if I'm wrong.)

I think there's a good argument for moving the *event_study functions into their own package, regardless. It would allow you to keep this package focused on its main objective without the dependency headaches. A event_study package would be a pretty natural fit for anyone looking for that set of functions too.

Thoughts?

@kylebutts
Copy link
Owner

I think I would be fine to this; would you submit a PR to here and https://github.com/kylebutts/event_study?

@grantmcdermott
Copy link
Collaborator Author

grantmcdermott commented Feb 2, 2023

Will do. Am i right in thinking that the direct deps of did2s are

  • stats,
  • methods,
  • boot,
  • Matrix
  • fixest,
  • Rcpp,
  • data.table, and
  • cli

?

@kylebutts
Copy link
Owner

Yes! I can get rid of cli too; just was being lazy :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants