Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercasing namespacing and chip namespace #5

Open
CvRXX opened this issue Dec 9, 2016 · 5 comments
Open

Lowercasing namespacing and chip namespace #5

CvRXX opened this issue Dec 9, 2016 · 5 comments
Assignees
@jacquelinekay

Comments

@CvRXX
Copy link
Contributor

CvRXX commented Dec 9, 2016

@odinthenerd and I really want all namespaces to be lowercase from now on. Could you implement that?

Also since all the files generated here are chip specific I think we should move it all to the kvasir::chip namespace. Do you agree?
@CvRXX CvRXX assigned CvRXX and jacquelinekay and unassigned CvRXX Dec 9, 2016
@odinthenerd
Copy link
Member

yeah it was probably a stupid idea to UpperCammelCase namespaces back in the day, doesn't seem natural to anyone but me ;)

@CvRXX
Copy link
Contributor Author

CvRXX commented Dec 9, 2016

It kind of ruins IDE

@jacquelinekay
Copy link
Collaborator

Yeah, the camelcase namespaces were bothering me.

@jacquelinekay
Copy link
Collaborator

Currently, structs defined by IO extensions are in the "Kvasir::Io" namespace (example). In the new scheme, should everything be in the "kvasir::chip" namespace?

@odinthenerd
Copy link
Member

Yes they should move to kvasir::chip::io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacquelinekay jacquelinekay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacquelinekay @CvRXX @odinthenerd