Source JSON firmware files from linux-firmware #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuruczgy
commented
Nov 17, 2024
They seem to be identical to the ones we had here, modulo the line endings. cdspr.jsn also seems to be missing, but I don't think this will cause issues.
kuruczgy
force-pushed
the
pr-json-firmware
branch
from
d0438fd to
302be5e
Compare
|
I am holding off on this because I am not actually sure whether these JSON files will be required at all when we switch to the in-kernel pd-mapper. We should first do that, and then get back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They seem to be identical to the ones we had here, modulo the line endings. cdspr.jsn also seems to be missing, but I don't think this will cause issues.
Closes #40