Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please remove window.close() from tab.js for Firefox #14

Open
jscher2000 opened this issue Oct 10, 2021 · 0 comments
Open

Please remove window.close() from tab.js for Firefox #14

jscher2000 opened this issue Oct 10, 2021 · 0 comments

Comments

@jscher2000
Copy link

https://github.com/kumar303/sound-control/blob/master/src/tab.js#L75

window.close() causes the focus to return to the window which had the popup. Firefox will close the popup automatically when the window loses focus, so window.close() is not needed in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jscher2000