Make namespace auto-generated name more unique #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yosiah de Koeyer <[email protected]>
Signed-off-by: Yosiah de Koeyer <[email protected]>
Y0sh1dk
requested review from
kensipe,
asekretenko and
kaiwalyajoshi
as code owners
Y0sh1dk
changed the title
Y0sh1dk
changed the title
porridge
reviewed
Jan 9, 2024
| @@ -385,7 +385,7 @@ func (t *Case) determineNamespace() *namespace { | |||
| } | |||
| // no preferred ns, means we auto-create with petnames | |||
| if t.PreferredNamespace == "" { | |||
| ns.Name = fmt.Sprintf("kuttl-test-%s", petname.Generate(2, "-")) | |||
| ns.Name = fmt.Sprintf("kuttl-test-%s", petname.Generate(4, "-")) | |||
There was a problem hiding this comment.
I'm more than a little afraid we might blow through the limit of max namespace length because of this. 😟
Or, more likely, when the code under test takes the namespace name as input to generating names of cluster-scoped resources (by slapping some additional prefix on it). Does petname provide any guarantees on the max generated name length?
|
An alternative would be to use a different string of similar length as the current one, but containing more entropy. I.e. use a string of random alphanumeric characters rather than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bump the auto-generated namespace name words from 2 -> 4 to reduce the chance of a clash.
Fixes #500