/kind bug

/help

@dhiller:
This request has been marked as needing help from a contributor.

Guidelines

• No Barrier to Entry
• Clear Task
• Solution Explained
• Provides Context
• Identifies Relevant Code
• Gives Examples
• Ready to Test
• Goldilocks priority
• Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

@dosu explain how kubectl.sh works

@dosu explain how kubectl.sh works

Is dosubot available on kubevirtci issues?

Not yet - I've just added it, will try again after indexing has completed.

@andreabolognani I just did make cluster-up on the latest kubevirt commit with KUBEVIRTCI_PROVIDER=k8s-1.31 set.

When I then did

bash -x ./cluster-up/kubectl.sh get nodes

output showed me

...
+++ kubectl=/home/dhiller/Projects/github.com/kubevirt.io/kubevirt/_ci-configs/k8s-1.31/.kubectl
...

which seems to indicate that it uses the kubectl binary which is copied from the cluster.

So I think we can

/close

this issue. Please chime in if you disagree.

@dhiller: Closing this issue.

/reopen

Apologies - it seems you were right, since I see here that instead of scping the file from the cluster, it seems it downloads a kubectl binary on the fly in case podman is in use:

FYI @brianmcarey

@dhiller: Reopened this issue.

@dosu please explain how the script kubectl.sh works

The kubectl.sh script operates by executing commands based on the first argument provided:

1. Environment Setup: It sets the KUBEVIRTCI_PATH if not already set, which is the directory path of the script.

2. Source Configuration: It sources several configuration scripts:

   • common.sh
   • provider.sh (specific to the KUBEVIRT_PROVIDER)
   • config.sh

3. Command Execution:

   • If the first argument is console, vnc, start, stop, or migrate, it calls virtctl.sh with all the arguments.
   • If the first argument is virt, it shifts the arguments and calls virtctl.sh with the remaining arguments.
   • For any other arguments, it calls the _kubectl function with all the arguments, which is a wrapper around the kubectl command.

The script is designed to manage virtual machine operations and Kubernetes commands without needing kubectl installed locally, as it can use a binary copied from the cluster or downloaded if Podman is used ^[1][2].

To continue talking to Dosu, mention @dosu.

FYI @brianmcarey

This brings up a fundamental point of kubectl.sh: instead of properly determining whether virtctl is even available it just forwards it. I think what it should do is check whether kubectl virt is available and use that in case the command execution tries to forward to virtctl binary.

@dhiller I just opened #1298 which seems to make the problem go away for me.