Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirtci, cluster-up: move cluster spin up logic into gocli #1110

Open
dhiller opened this issue Dec 22, 2023 · 19 comments
Open

kubevirtci, cluster-up: move cluster spin up logic into gocli #1110

dhiller opened this issue Dec 22, 2023 · 19 comments
Labels
good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors.

Comments

@dhiller
Copy link
Contributor

dhiller commented Dec 22, 2023

We currently have the logic of spinning up a KubeVirtCI cluster inside the cluster-up folder of kubevirt/kubevirtci.

This is sourced into kubevirt/kubevirt. An update of kubevirtci updates the sourced folder. Other users of kubevirtci clone the repo on the fly.

Let's move all the logic of cluster-up into gocli, this way we only need to update the tag of the gocli image for a cluster update.

@dhiller
Copy link
Contributor Author

dhiller commented Dec 22, 2023

FYI @xpivarc

Did this issue somehow capture what you suggested?

@dhiller
Copy link
Contributor Author

dhiller commented Dec 22, 2023

FYI @brianmcarey

@xpivarc
Copy link
Member

xpivarc commented Jan 2, 2024

It sounds good to me, I see less and less value in having it. (revering to the cluster-up folder)

@dhiller
Copy link
Contributor Author

dhiller commented Mar 12, 2024

FYI @brianmcarey

/good-first-issue

@kubevirt-bot
Copy link
Contributor

@dhiller:
This request has been marked as suitable for new contributors.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

FYI @brianmcarey

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. labels Mar 12, 2024
@oshoval
Copy link
Contributor

oshoval commented Mar 12, 2024

Please note there is kind-sriov provider which all its logic is on cluster-up folder bash scripts

imho it isn't "good first issue"

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 10, 2024
@xpivarc
Copy link
Member

xpivarc commented Jul 11, 2024

@dhiller @brianmcarey Please note that @aerosouund is working on kubevirt/community#257. First PR in series would be #1209.

@aerosouund aerosouund mentioned this issue Jul 11, 2024
8 tasks
@aerosouund aerosouund mentioned this issue Jul 23, 2024
8 tasks
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@brianmcarey
Copy link
Member

/reopen

@kubevirt-bot
Copy link
Contributor

@brianmcarey: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhiller
Copy link
Contributor Author

dhiller commented Sep 10, 2024

/remove-lifecycle rotten
/reopen

@kubevirt-bot
Copy link
Contributor

@dhiller: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot reopened this Sep 10, 2024
@kubevirt-bot kubevirt-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 10, 2024
@SWITCHin2
Copy link

Hey maintainers,
Is this issue still opened and what are the works left as I can see the series of PRs for this enhancement.
cc: @dhiller

@aerosouund
Copy link
Member

@SWITCHin2
The code for this issue is already mostly written, but the community is still reviewing and discussing the changes due to their size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors.
Projects
None yet
Development

No branches or pull requests

7 participants