Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: split bundle files for different arches #655

Merged
merged 1 commit into from
Dec 10, 2024
Merged

release: split bundle files for different arches #655

merged 1 commit into from
Dec 10, 2024

Conversation

fossedihelm
Copy link
Contributor

What this PR does / why we need it:
Create separate bundle files and upload them.
Also, release action will push both bundles to
ssp-operator

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Create separate bundles for specific architectures

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 10, 2024
@fossedihelm fossedihelm force-pushed the fix-release-arch-bundle branch 2 times, most recently from f30eedc to 1c4c8ee Compare December 10, 2024 05:34
@fossedihelm
Copy link
Contributor Author

/cc @0xFelix

@kubevirt-bot kubevirt-bot requested a review from 0xFelix December 10, 2024 08:26
@fossedihelm
release: add arch specific bundles
6346c99 
Create arch specific bundle files and upload them.
Updated the plugin used to update files.
Also, release action will push all the bundles to
ssp-operator.

Signed-off-by: fossedihelm <[email protected]>
@fossedihelm fossedihelm force-pushed the fix-release-arch-bundle branch from 1c4c8ee to 6346c99 Compare December 10, 2024 09:36
0xFelix
0xFelix approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@0xFelix
Copy link
Member

0xFelix commented Dec 10, 2024

/override ?

@kubevirt-bot
Copy link
Contributor

@0xFelix: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-gcp-common-templates-centos-stream9
  • ci/prow/e2e-gcp-common-templates-centos6
  • ci/prow/e2e-gcp-common-templates-fedora
  • ci/prow/e2e-gcp-common-templates-opensuse
  • ci/prow/e2e-gcp-common-templates-rhel7
  • ci/prow/e2e-gcp-common-templates-rhel8
  • ci/prow/e2e-gcp-common-templates-rhel9
  • ci/prow/e2e-gcp-common-templates-ubuntu
  • ci/prow/e2e-gcp-common-templates-unit-tests
  • ci/prow/e2e-gcp-common-templates-windows10
  • ci/prow/e2e-gcp-common-templates-windows11
  • ci/prow/e2e-gcp-common-templates-windows2016
  • ci/prow/e2e-gcp-common-templates-windows2019
  • ci/prow/e2e-gcp-common-templates-windows2022
  • ci/prow/e2e-gcp-common-templates-windows2025
  • ci/prow/e2e-gcp-go-tests
  • dco
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@0xFelix
Copy link
Member

0xFelix commented Dec 10, 2024

/override ci/prow/e2e-gcp-common-templates-centos-stream9
/override ci/prow/e2e-gcp-common-templates-centos6
/override ci/prow/e2e-gcp-common-templates-fedora
/override ci/prow/e2e-gcp-common-templates-opensuse
/override ci/prow/e2e-gcp-common-templates-rhel7
/override ci/prow/e2e-gcp-common-templates-rhel8
/override ci/prow/e2e-gcp-common-templates-rhel9
/override ci/prow/e2e-gcp-common-templates-ubuntu
/override ci/prow/e2e-gcp-common-templates-unit-tests
/override ci/prow/e2e-gcp-common-templates-windows10
/override ci/prow/e2e-gcp-common-templates-windows11
/override ci/prow/e2e-gcp-common-templates-windows2016
/override ci/prow/e2e-gcp-common-templates-windows2019
/override ci/prow/e2e-gcp-common-templates-windows2022
/override ci/prow/e2e-gcp-common-templates-windows2025

@kubevirt-bot
Copy link
Contributor

@0xFelix: Overrode contexts on behalf of 0xFelix: ci/prow/e2e-gcp-common-templates-centos-stream9, ci/prow/e2e-gcp-common-templates-centos6, ci/prow/e2e-gcp-common-templates-fedora, ci/prow/e2e-gcp-common-templates-opensuse, ci/prow/e2e-gcp-common-templates-rhel7, ci/prow/e2e-gcp-common-templates-rhel8, ci/prow/e2e-gcp-common-templates-rhel9, ci/prow/e2e-gcp-common-templates-ubuntu, ci/prow/e2e-gcp-common-templates-unit-tests, ci/prow/e2e-gcp-common-templates-windows10, ci/prow/e2e-gcp-common-templates-windows11, ci/prow/e2e-gcp-common-templates-windows2016, ci/prow/e2e-gcp-common-templates-windows2019, ci/prow/e2e-gcp-common-templates-windows2022, ci/prow/e2e-gcp-common-templates-windows2025

In response to this:

/override ci/prow/e2e-gcp-common-templates-centos-stream9
/override ci/prow/e2e-gcp-common-templates-centos6
/override ci/prow/e2e-gcp-common-templates-fedora
/override ci/prow/e2e-gcp-common-templates-opensuse
/override ci/prow/e2e-gcp-common-templates-rhel7
/override ci/prow/e2e-gcp-common-templates-rhel8
/override ci/prow/e2e-gcp-common-templates-rhel9
/override ci/prow/e2e-gcp-common-templates-ubuntu
/override ci/prow/e2e-gcp-common-templates-unit-tests
/override ci/prow/e2e-gcp-common-templates-windows10
/override ci/prow/e2e-gcp-common-templates-windows11
/override ci/prow/e2e-gcp-common-templates-windows2016
/override ci/prow/e2e-gcp-common-templates-windows2019
/override ci/prow/e2e-gcp-common-templates-windows2022
/override ci/prow/e2e-gcp-common-templates-windows2025

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fossedihelm fossedihelm mentioned this pull request Dec 10, 2024
Closed
@0xFelix
Copy link
Member

0xFelix commented Dec 10, 2024

/override ci/prow/e2e-gcp-go-tests

@kubevirt-bot
Copy link
Contributor

@0xFelix: Overrode contexts on behalf of 0xFelix: ci/prow/e2e-gcp-go-tests

In response to this:

/override ci/prow/e2e-gcp-go-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit 0f04680 into kubevirt:master Dec 10, 2024
19 checks passed
@0xFelix
Copy link
Member

0xFelix commented Dec 10, 2024

/cherry-pick release-v0.32

@kubevirt-bot
Copy link
Contributor

@0xFelix: new pull request created: #657

In response to this:

/cherry-pick release-v0.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fossedihelm @kubevirt-bot @0xFelix