Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/lint.sh: There are warnings which are ignored #304

Open
0xFelix opened this issue Dec 18, 2024 · 0 comments
Open

scripts/lint.sh: There are warnings which are ignored #304

0xFelix opened this issue Dec 18, 2024 · 0 comments
Labels

Comments

@0xFelix
Copy link
Member

0xFelix commented Dec 18, 2024

What happened:

scripts/lint.sh runs yamllint with -d relaxed which leads to some errors becoming warnings instead. yamllint does exit with code 0 if only warnings were found, which leads to warnings being silently ignored when linting in presubmit lanes.

What you expected to happen:

yamllint should be as strict as possible, so we don't ignore warnings silently.

How to reproduce it (as minimally and precisely as possible):

Look at log output of pull-common-instancetypes lane.

Additional context:
Add any other context about the problem here.

Environment:

  • KubeVirt version (use virtctl version): N/A
  • Kubernetes version (use kubectl version): N/A
  • VM or VMI specifications: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Install tools: N/A
  • Others: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant