make the openstack vm image based and have a volume attached #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
openstack-imagebased
branch
2 times, most recently
from
0af4985 to
4b01b46
Compare
ahadas
reviewed
Mar 19, 2024
cluster/common.sh
Outdated
| @@ -28,9 +28,9 @@ function k8s_grant_permissions { | |||
|
|
|||
| # workaround to https://github.com/kubevirt/kubevirt/issues/7078 | |||
| function k8s_patch_storage_profile { | |||
| kubectl patch --type merge -p '{"spec": {"claimPropertySets": [{"accessModes": ["ReadWriteOnce"]}]}}' StorageProfile standard | |||
| kubectl patch --type merge -p '{"spec": {"claimPropertySets": [{ "volumeMode": "Filesystem", "accessModes": ["ReadWriteOnce"]}]}}' StorageProfile standard | |||
There was a problem hiding this comment.
please post this change in a separate PR
|
Signed-off-by: Benny Zlotnik <[email protected]>
ahadas
force-pushed
the
openstack-imagebased
branch
from
4b01b46 to
e14d62b
Compare
ahadas
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.