virt-v2v: Replace the Get-Disk and Set-Disk with diskpart #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: The Get-Disk and Set-Disk do not support dynamic disks. https://learn.microsoft.com/en-us/powershell/module/storage/get-disk?view=windowsserver2022-ps Signed-off-by: Martin Necas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
=======================================
Coverage 16.21% 16.21%
=======================================
Files 106 106
Lines 19543 19541 -2
=======================================
+ Hits 3168 3169 +1
+ Misses 16094 16092 -2
+ Partials 281 280 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fabiand
requested changes
Aug 22, 2024
Comment on lines
+18
to
+26
| foreach ($disk in $disks) { | ||
| $diskNumber = $disk.Index # Get the disk index which corresponds to the disk number | ||
|
|
||
| # Create a diskpart script to set the disk online | ||
| $diskpartScript = @" | ||
| select disk $diskNumber | ||
| online disk | ||
| attributes disk clear readonly | ||
| "@ |
There was a problem hiding this comment.
This feels quie risky to me.
Take an index from one tool/api, and use it in a different tool/api.
This is just waiting for indexes to be out of sync for whatever reason.
There was a problem hiding this comment.
100% agree and I would like to not use the diskpart
|
Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The Get-Disk and Set-Disk do not support dynamic disks. https://learn.microsoft.com/en-us/powershell/module/storage/get-disk?view=windowsserver2022-ps