Set resource requests for forklift-operator #765
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 15.98% 15.94% -0.05%
==========================================
Files 106 106
Lines 19714 19714
==========================================
- Hits 3152 3143 -9
- Misses 16284 16295 +11
+ Partials 278 276 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm uncertain how we should know what is the memory and CPU resources that would fit the "golden zone"(more than minimal, but not exhausting them). we can start with your PR and see if a problem appear? |
The forklift-operator pod is not CPU intensive, so minimal CPU time should be sufficient. When it comes to memory, in some environments it consumes ~40Mi and in others ~100Mi, so asking for 64Mi seems reasonable. Signed-off-by: Arik Hadas <[email protected]>
ahadas
force-pushed
the
operator_resource_requests
branch
from
5a96f7a to
c9059b5
Compare
|
it's unlikely that we'll see a problem because currently we don't set a request for memory so the memory consumption of the operator pod is not taken into consideration when scheduling the pod and it may end up running on a node that doesn't have enough memory available. so if the pod tries to allocate more than 64Mi and there's not enough memory available - we're at the same situation. and 64Mi is more or less what the pod takes, so we don't reserve significantly more than it needs. and as for CPU, the operator pod is not CPU intensive - asking for 10% of what the main container in the forklift-controller pod asks for sounds reasonable updated the commit message to have this documented |
The forklift-operator pod is not CPU intensive, so minimal CPU time should be sufficient. When it comes to memory, in some environments it consumes ~40Mi and in others ~100Mi, so asking for 64Mi seems reasonable.
see this