Make the block overhead configurable (backport) #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch will allow the user to configure the block overhead. Currently it defaults to 0. The overhead is required when migrating to encrypted Ceph RBD (block). The pod may see less space on the disk and therefore the migration will fail when it tries to allocate the last sectors. See more about encrypted Ceph RBD in: https://docs.ceph.com/en/quincy/rbd/rbd-encryption/ The value needs to be set in the ForkliftController spec under the value: `controller_block_overhead`. The addition will be the fixed number provided to the size of the disk. Signed-off-by: Liran Rotenberg <[email protected]>
liranr23
requested review from
ahadas,
bennyz,
mmartinv and
mnecas
as code owners
ahadas
approved these changes
Dec 12, 2023
When specifying resources like disk sizes, the value is expected to represent a quantity rather than an integer so users can set values like "1Gi". Applying this to controller_block_overhead as well. Signed-off-by: Arik Hadas <[email protected]>
ahadas
approved these changes
Dec 12, 2023
Signed-off-by: Liran Rotenberg <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will allow the user to configure the block overhead. Currently it defaults to 0. The overhead is required when migrating to encrypted Ceph RBD (block). The pod may see less space on the disk and therefore the migration will fail when it tries to allocate the last sectors. See more about encrypted Ceph RBD in:
https://docs.ceph.com/en/quincy/rbd/rbd-encryption/
The value needs to be set in the ForkliftController spec under the value:
controller_block_overhead. The addition will be the fixed number provided to the size of the disk.