Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OVA: Add support for removing deleted vms from the inventory #659

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

bkhizgiy
Copy link
Member

@bkhizgiy bkhizgiy commented Nov 20, 2023

Currently when a VM is deleted from the NFS share it is not removed from the inventory, this change will support it.

https://issues.redhat.com/browse/MTV-733

@bkhizgiy bkhizgiy requested a review from ahadas as a code owner November 20, 2023 17:28
@bkhizgiy bkhizgiy changed the title WIP: add support for removing deleted vms from the inventory Add support for removing deleted vms from the inventory Nov 21, 2023
@bkhizgiy bkhizgiy requested review from bennyz and liranr23 November 23, 2023 14:39
@ahadas ahadas changed the title Add support for removing deleted vms from the inventory OVA: Add support for removing deleted vms from the inventory Nov 27, 2023
@ahadas ahadas linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments, overall looks good, but please also change the commit message (I edited the description of the PR)

pkg/controller/provider/container/ova/collector.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/collector.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/ova/model.go Outdated Show resolved Hide resolved
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkhizgiy also the commit message is empty (besides the title), no?

Currently, when a VM is deleted from the NFS share it is not removed
from the inventory. With this change it will be removed.

Signed-off-by: Bella Khizgiyaev <[email protected]>
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ahadas ahadas merged commit 91b7567 into kubev2v:main Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OVA inventory watch to detect deleted files
2 participants