Set Hyperv features from KubeVirt template #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The features and clock settings are taken from the corresponding template in kubevirt, if exists, we do not want to override them with empty settings. Signed-off-by: Arik Hadas <[email protected]>
liranr23
approved these changes
Nov 6, 2023
The features and clock settings are taken from the corresponding template in kubevirt, if exists, we do not want to override them with empty settings. Signed-off-by: Arik Hadas <[email protected]>
The features and clock settings are taken from the corresponding template in kubevirt, if exists, we do not want to override them with empty settings. Signed-off-by: Arik Hadas <[email protected]>
The features are taken from the corresponding template in kubevirt, if exists, we do not want to override them with empty settings. Signed-off-by: Arik Hadas <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrate from oVirt, vSphere, OpenStack and OVA, we override the Features and Clock sections of the VMs that are based on the template in KubeVirt that corresponds to the operating system of the migrated VM, if such a template exists. This PR changes the relevant Builders to avoid overriding these sections with empty settings. It's OK to override fields that are taken from the template with values based on the configuration of VMs in the source system, but it makes no sense to override fields from the template with empty values, as for example it clears Hyperv features that are useful for Windows guests.
When we take Hyperv flags from the template, we need to make sure that the clock is also taken from the template (since it needs to be Hypervclock).
https://issues.redhat.com/browse/MTV-791