Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazelify ova-provider #621

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Bazelify ova-provider #621

merged 2 commits into from
Oct 11, 2023

Conversation

liranr23
Copy link
Member

Build the ova provider server image using bazel.

@liranr23
Bazelify ova-provider
fb4faa7 
Build the ova provider server image using bazel.

Signed-off-by: Liran Rotenberg <[email protected]>
@liranr23
update zap and x go dependencies
01ca4ee 
Signed-off-by: Liran Rotenberg <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13464 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@liranr23
Copy link
Member Author

i can drop the bump of the 2 dependencies.

ahadas
ahadas approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved the two issues that were reported by sonarcloud

@ahadas ahadas marked this pull request as ready for review October 11, 2023 11:52
@ahadas
Copy link
Member

ahadas commented Oct 11, 2023

@liranr23 did you do sanity test of the ova provider?

@liranr23
Copy link
Member Author

@liranr23 did you do sanity test of the ova provider?

not yet. tried to figure first what to do with the sonarcloud.

@ahadas
Copy link
Member

ahadas commented Oct 11, 2023 •
edited
Loading

@liranr23 you can merge it once a sanity check passes, @bkhizgiy works on an end-to-end test

@liranr23 liranr23 merged commit c889861 into kubev2v:main Oct 11, 2023
8 checks passed
@liranr23 liranr23 deleted the bazelify_ova_provider branch October 11, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@bennyz bennyz Awaiting requested review from bennyz

@mmartinv mmartinv Awaiting requested review from mmartinv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liranr23 @ahadas