Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go version to 1.20 #620

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Bump go version to 1.20 #620

merged 2 commits into from
Oct 15, 2023

Conversation

liranr23
Copy link
Member

No description provided.

@liranr23 liranr23 force-pushed the bump_go branch 2 times, most recently from 7923a18 to 3b4f963 Compare October 11, 2023 10:26
ahadas
ahadas reviewed Oct 11, 2023
View reviewed changes
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
WORKSPACE Outdated Show resolved Hide resolved
@liranr23 @ahadas
Bump go version to 1.20
73a5233 
Signed-off-by: Liran Rotenberg <[email protected]>
@liranr23
Bump govmomi client
c3b843b 
Go 1.20 introduces a new error type for connection. It caused a failure
to vSphere provider connect. It fixed in a newer govmomi release.

Signed-off-by: Liran Rotenberg <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 90 Security Hotspots
Code Smell A 55 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@liranr23 liranr23 marked this pull request as ready for review October 12, 2023 15:32
@liranr23 liranr23 requested a review from nyoxi as a code owner October 12, 2023 15:32
@nyoxi
Copy link
Member

nyoxi commented Oct 13, 2023

I don't know if it is OK to patch our vendored dependencies, but to make SonarCloud happy a change in govmomi is needed, specifically in vendor/github.com/vmware/govmomi/Dockerfile.govc.

COPY --chown=appuser --from=build /temporary-tmp-directory /tmp
to something like:
COPY --chown=appuser --chmod=644 --from=build /temporary-tmp-directory /tmp

@ahadas
Copy link
Member

ahadas commented Oct 15, 2023 •
edited
Loading

I don't know if it is OK to patch our vendored dependencies, but to make SonarCloud happy a change in govmomi is needed, specifically in vendor/github.com/vmware/govmomi/Dockerfile.govc.

COPY --chown=appuser --from=build /temporary-tmp-directory /tmp to something like: COPY --chown=appuser --chmod=644 --from=build /temporary-tmp-directory /tmp

I suspect that our CI job would then fail. That's ok, as the risk is low, we can ignore that

@ahadas ahadas merged commit cd07cc3 into kubev2v:main Oct 15, 2023
7 of 8 checks passed
@liranr23 liranr23 deleted the bump_go branch October 15, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@nyoxi nyoxi nyoxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liranr23 @nyoxi @ahadas