Backport https://github.com/kubev2v/forklift/pull/592 #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bella Khizgiyaev <[email protected]>
|
Note: the |
bkhizgiy
force-pushed
the
release-v2.5.1
branch
from
45a8173 to
b6519bd
Compare
ahadas
reviewed
Oct 4, 2023
for backport kubev2v#592 Signed-off-by: Bella Khizgiyaev <[email protected]>
bkhizgiy
force-pushed
the
release-v2.5.1
branch
from
b6519bd to
94a337b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now when adding a new OVA provider we were mount the NFS volume directly to the server/ conversion pod, this worked for some of the cases but wasn't supported on a restricted or different namespaces from forklift/MTV since NFS is not permitted. This fix switch the use of NFS to used shared PVC for both of the cases instead.
backport of #592