Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout of validation webhooks to 30 seconds #607

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Sep 28, 2023

10 seconds are usually enough but in some cases, it takes few seconds to instantiate a client for interacting with the cluster and then this 10 seconds timeout is reached. Therefore, aligning the timeout of the validation webhooks with that of mutating webhooks.

@ahadas ahadas requested review from liranr23 and bkhizgiy September 28, 2023 09:54
@ahadas ahadas requested a review from mnecas as a code owner September 28, 2023 09:54
@ahadas ahadas requested a review from bennyz September 28, 2023 09:54
@ahadas ahadas changed the title Increase timeout of validation webhook to 30 seconds Increase timeout of validation webhooks to 30 seconds Sep 28, 2023
10 seconds are usually enough but in some cases, it takes few seconds to
instantiate a client for interacting with the cluster and then this
10 seconds timeout is reached. Therefore, aligning the timeout of the
validation webhooks with that of mutating webhooks.

Signed-off-by: Arik Hadas <[email protected]>
@ahadas ahadas force-pushed the validation_webhooks_timeout branch from bb7ec53 to df7f260 Compare September 28, 2023 09:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ahadas ahadas merged commit b0b4596 into kubev2v:main Sep 28, 2023
6 of 7 checks passed
@ahadas ahadas deleted the validation_webhooks_timeout branch September 28, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants