Single webhook per configuration entity #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've noticed an unexpected behavior in OpenShift: 1. ValidatingWebhookConfiguration or MutatingWebhookConfiguration is posted with a webhook 2. CA bundle is injected to the webhook 3. More webhooks are added to the configuration entity 4. Some of the webhooks (in our case it has always been the last one) does not get a CA bundle injected This is a workaround for this issue - avoid adding webhooks to an existing configuration entity by separating each webhook to a different configuration entity. Signed-off-by: Arik Hadas <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
will it be possible to hit the issue once all of the existing configurations are set and we change one of them? what will happen in that case? couldn't we just update the existing configurations? |
there's no problem with changing them, this issue happens when adding webhooks - so as long as you don't add webhooks to existing configuration entity, it would be fine |
liranr23
approved these changes
Sep 20, 2023
bennyz
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed an unexpected behavior in OpenShift:
This is a workaround for this issue - avoid adding webhooks to an existing configuration entity by separating each webhook to a different configuration entity.