OVA: changing nfs mount to server and conversion pod to use shared PVC #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhizgiy
changed the title
|
The PR is ready and was tested on different namespaces, both the provider adding and migrations.
|
liranr23
reviewed
Sep 18, 2023
|
Still need to be tested, having some issue with my env. |
ahadas
reviewed
Oct 1, 2023
liranr23
reviewed
Oct 3, 2023
liranr23
reviewed
Oct 3, 2023
bkhizgiy
force-pushed
the
namespace
branch
2 times, most recently
from
083bbac to
53a2b98
Compare
|
Was tested also for restricted namespace and the entire flow was as expected. |
|
CI setup fails due to non-existing RPM dep of the ovirt-populator. #617 should fix it. |
Signed-off-by: Bella Khizgiyaev <[email protected]>
Signed-off-by: Liran Rotenberg <[email protected]>
ahadas
reviewed
Oct 3, 2023
bkhizgiy
force-pushed
the
namespace
branch
2 times, most recently
from
af0df68 to
eb8fccf
Compare
ahadas
reviewed
Oct 4, 2023
ahadas
reviewed
Oct 4, 2023
Signed-off-by: Bella Khizgiyaev <[email protected]>
Signed-off-by: Bella Khizgiyaev <[email protected]>
ahadas
approved these changes
Oct 4, 2023
liranr23
approved these changes
Oct 4, 2023
Signed-off-by: Arik Hadas <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
bkhizgiy
added a commit
to bkhizgiy/forklift
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Bella Khizgiyaev <[email protected]>
bkhizgiy
added a commit
to bkhizgiy/forklift
that referenced
this pull request
Oct 4, 2023
for backport kubev2v#592 Signed-off-by: Bella Khizgiyaev <[email protected]>
bkhizgiy
added a commit
to bkhizgiy/forklift
that referenced
this pull request
Oct 4, 2023
for backport kubev2v#592 Signed-off-by: Bella Khizgiyaev <[email protected]>
bkhizgiy
added a commit
to bkhizgiy/forklift
that referenced
this pull request
Oct 4, 2023
for backport kubev2v#592 Signed-off-by: Bella Khizgiyaev <[email protected]>
ahadas
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Bella Khizgiyaev <[email protected]>
ahadas
pushed a commit
that referenced
this pull request
Oct 4, 2023
for backport #592 Signed-off-by: Bella Khizgiyaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now when adding a new OVA provider we were mount the NFS volume directly to the server/ conversion pod, this worked for some of the cases but wasn't supported on a restricted or different namespaces from forklift/MTV since NFS is not permitted. This fix switch the use of NFS to used shared PVC for both of the cases instead.