feat: expose ability to skip vsphere guest conversion #1279
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
=======================================
Coverage 15.44% 15.44%
=======================================
Files 112 112
Lines 23399 23399
=======================================
Hits 3613 3613
Misses 19501 19501
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a field to the Provider CR to toggle on/off Guest OS conversion using virt-v2v-in-place. In the event that a guest OS cannot be converted with virt-v2v, this will give users the ability to do a simpler transfer, with no conversion.
After this "simple" migration, the new KubeVirt VM will be bootable, but will require some manual work by the user to install drivers etc.
This should be added along side the changes in #1109
The
convertDiskflag is optional. Leaving it blank will result in the same behaviour as now.