MTV-1493 | Add missing resource limits and requests #1268
Conversation
| @@ -1738,6 +1748,16 @@ func (r *KubeVirt) guestConversionPod(vm *plan.VMStatus, vmVolumes []cnv.Volume, | |||
| MountPath: "/opt", | |||
| }, | |||
| }, | |||
| Resources: core.ResourceRequirements{ | |||
There was a problem hiding this comment.
Init container only for mount, don't think we need it to be configurable.
| @@ -1016,6 +1017,16 @@ func createVddkCheckJob(plan *api.Plan) *batchv1.Job { | |||
| Drop: []core.Capability{"ALL"}, | |||
| }, | |||
| }, | |||
| Resources: core.ResourceRequirements{ | |||
There was a problem hiding this comment.
Init container only for mount, don't think we need it to be configurable.
| @@ -1057,7 +1068,17 @@ func createVddkCheckJob(plan *api.Plan) *batchv1.Job { | |||
| InitContainers: initContainers, | |||
| Containers: []core.Container{ | |||
| { | |||
| Name: "validator", | |||
| Name: "validator", | |||
There was a problem hiding this comment.
Validation contianer only for mount, don't think we need it to be configurable.
mnecas
force-pushed
the
MTV-1493
branch
5 times, most recently
from
5034c23 to
e61e86b
Compare
Issue: If the user sets ClusterResourceQuota the Forklift will start failing as it does not have the limits or requests on the pods which are created form the Forklift Controller. Fix: Add a new parameters to Forklift operator which can be configured depedning on the user env. Ref: https://issues.redhat.com/browse/MTV-1493 Signed-off-by: Martin Necas <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
- Coverage 15.53% 15.49% -0.04%
==========================================
Files 112 112
Lines 23262 23381 +119
==========================================
+ Hits 3613 3624 +11
- Misses 19364 19470 +106
- Partials 285 287 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue:
If the user sets ClusterResourceQuota the Forklift will start failing as it does not have the limits or requests on the pods which are created form the Forklift Controller.
Fix:
Add a new parameters to Forklift operator which can be configured depedning on the user env.
Ref: https://issues.redhat.com/browse/MTV-1493