MTV-1767 | Add wait for snapshot removal timeout #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: The migration fails with `Another task is already in progress`. This is caused because of the snapshot creation is started right after snapshot removal and the snapshot removal did not finish due to the consolidation. Fix: I have added a timeout which users can control using the `controller_snapshot_removal_check_retries` variable. This will wait some time right after snapshot removal. This is just a temporary solution to unblock the users. I'll fix it properly using the VM events and tasks, but that will require a lot of changes in the controller inventory and main. Ref: https://issues.redhat.com/browse/MTV-1753 Signed-off-by: Martin Necas <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 15.54% 15.56% +0.01%
==========================================
Files 112 112
Lines 23233 23255 +22
==========================================
+ Hits 3612 3620 +8
- Misses 19336 19347 +11
- Partials 285 288 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Merging for 2.7.6 release any notes I'll address in further PRs |
This was referenced Dec 9, 2024
Merged
mnecas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The migration fails with
Another task is already in progress. This is caused because of the snapshot creation is started right after snapshot removal and the snapshot removal did not finish due to the consolidation.Fix: I have added a timeout which users can control using the
controller_snapshot_removal_check_retriesvariable. This will wait some time right after snapshot removal. This is just a temporary solution to unblock the users. I'll fix it properly using the VM events and tasks, but that will require a lot of changes in the controller inventory and main.Ref: https://issues.redhat.com/browse/MTV-1767