Support specifying the transfer net by configmap #1241
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
k8s.v1.cni.cncf.org/networks
annotation supports a json value with a list of NetworkSelectionElements that contain additional configuration for the secondary network attachment, including a default route.This change allows the user to specify the transfer network by referencing a ConfigMap that contains a
NetworkSelectionElement
. The Plan CR already uses an ObjectReference type for thetransferNetwork
field, so we can take advantage of thekind
field on the ObjectReference to specify that a ConfigMap is being used without having to make any changes to the Plan CR. The transfer network validation has been expanded to check that the ConfigMap is in the correct format and that the NAD the ConfigMap refers to exists.To maintain compatibility with previous versions of Forklift, the original behavior (using the
v1.multus-cni.io/default-network
annotation) is preserved if a ConfigMap is not specified in the Plan.