Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Vlan IDs #1225

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fetch Vlan IDs #1225

merged 1 commit into from
Nov 29, 2024

Conversation

machacekondra
Copy link
Contributor

@machacekondra machacekondra commented Nov 27, 2024

This PR add a support for fetching VlanIDs for the DVPortGroups and standart porgroups.

Jira: https://issues.redhat.com/browse/ECOPROJECT-2359

@mnecas
Copy link
Member

mnecas commented Nov 28, 2024

Please link some issues showing why/where you need it.
It does not need to be issue directly on Forklift but could be from your project.

@machacekondra machacekondra force-pushed the vlanid branch 2 times, most recently from b5a0ad7 to 55ebfff Compare November 28, 2024 10:46
pkg/controller/provider/web/vsphere/network.go Outdated Show resolved Hide resolved
pkg/controller/provider/container/vsphere/model.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 28, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 15.62%. Comparing base (4d6a3f1) to head (dabe1d1).

Files with missing lines Patch % Lines
pkg/controller/provider/container/vsphere/model.go 0.00% 14 Missing ⚠️
...controller/provider/container/vsphere/collector.go 0.00% 1 Missing ⚠️
pkg/controller/provider/web/vsphere/network.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
- Coverage   15.63%   15.62%   -0.02%     
==========================================
  Files         112      112              
  Lines       23107    23123      +16     
==========================================
  Hits         3612     3612              
- Misses      19210    19226      +16     
  Partials      285      285              
Flag Coverage Δ
unittests 15.62% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mnecas mnecas merged commit 4890e07 into kubev2v:main Nov 29, 2024
13 of 14 checks passed
@@ -306,6 +307,7 @@ func (v *HostAdapter) Apply(u types.ObjectUpdate) {
Key: portGroup.Key,
Name: portGroup.Spec.Name,
Switch: portGroup.Vswitch,
VlanId: portGroup.Spec.VlanId,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants