-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch Vlan IDs #1225
Fetch Vlan IDs #1225
Conversation
Please link some issues showing why/where you need it. |
b5a0ad7
to
55ebfff
Compare
Jira: https://issues.redhat.com/browse/ECOPROJECT-2359 Signed-off-by: Ondra Machacek <[email protected]>
55ebfff
to
dabe1d1
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
- Coverage 15.63% 15.62% -0.02%
==========================================
Files 112 112
Lines 23107 23123 +16
==========================================
Hits 3612 3612
- Misses 19210 19226 +16
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -306,6 +307,7 @@ func (v *HostAdapter) Apply(u types.ObjectUpdate) { | |||
Key: portGroup.Key, | |||
Name: portGroup.Spec.Name, | |||
Switch: portGroup.Vswitch, | |||
VlanId: portGroup.Spec.VlanId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR add a support for fetching VlanIDs for the DVPortGroups and standart porgroups.
Jira: https://issues.redhat.com/browse/ECOPROJECT-2359