Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression virtio win driver for v2v #1215

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Nov 26, 2024

Regression introduced by: #1214
When running the ./hack/virt-v2v-rpm-deps.sh it will automatically replace the newer driver with the older available drivers.

@mnecas mnecas requested a review from yaacov as a code owner November 26, 2024 21:26
Regression introduced by: kubev2v#1214
When running the `./hack/virt-v2v-rpm-deps.sh` it will automatically
replace the newer driver with the older available drivers.

Signed-off-by: Martin Necas <[email protected]>
@mnecas mnecas force-pushed the fix_v2v_win_virtio branch from 931a03f to 885ad6e Compare November 26, 2024 21:31
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.65%. Comparing base (40a806e) to head (885ad6e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
- Coverage   15.69%   15.65%   -0.04%     
==========================================
  Files         112      112              
  Lines       23071    23071              
==========================================
- Hits         3620     3612       -8     
- Misses      19163    19174      +11     
+ Partials      288      285       -3     
Flag Coverage Δ
unittests 15.65% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas merged commit f9b0fad into kubev2v:main Nov 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants