Fix virt-v2v image build #1214
Merged
Fix virt-v2v image build #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Necas <[email protected]>
Issue: When running `make build-virt-v2v-image` the build failed due to some packages throwing 404. Fix: I needed to change the rpm url from AppStream to BaseOs for perl packages. It was not detected by the `./hack/virt-v2v-rpm-deps.sh` as the packages did not change (did not got updated) but only their location changed. Might be issue in the bazeldnf rpmtree. Fixes: kubev2v#1205 Signed-off-by: Martin Necas <[email protected]>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 15.65% 15.65%
=======================================
Files 112 112
Lines 23075 23071 -4
=======================================
Hits 3612 3612
+ Misses 19178 19174 -4
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnecas
added a commit
to mnecas/forklift
that referenced
this pull request
Nov 26, 2024
Regression introduced by: kubev2v#1214 When running the `./hack/virt-v2v-rpm-deps.sh` it will automatically replace the newer driver with the older available drivers. Signed-off-by: Martin Necas <[email protected]>
mnecas
added a commit
to mnecas/forklift
that referenced
this pull request
Nov 26, 2024
Regression introduced by: kubev2v#1214 When running the `./hack/virt-v2v-rpm-deps.sh` it will automatically replace the newer driver with the older available drivers. Signed-off-by: Martin Necas <[email protected]>
mnecas
added a commit
that referenced
this pull request
Nov 26, 2024
Regression introduced by: #1214 When running the `./hack/virt-v2v-rpm-deps.sh` it will automatically replace the newer driver with the older available drivers. Signed-off-by: Martin Necas <[email protected]>
mnecas
added a commit
that referenced
this pull request
Nov 26, 2024
Regression introduced by: #1214 When running the `./hack/virt-v2v-rpm-deps.sh` it will automatically replace the newer driver with the older available drivers. Signed-off-by: Martin Necas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix virt-v2v image build
Issue: When running
make build-virt-v2v-imagethe build failed due tosome packages throwing 404.
Fix: I needed to change the rpm url from AppStream to BaseOs for perl
packages. It was not detected by the
./hack/virt-v2v-rpm-deps.shasthe packages did not change (did not got updated) but only their
location changed. Might be issue in the bazeldnf rpmtree.
Fixes: #1205
Signed-off-by: Martin Necas [email protected]