MTV-1693 | Ignore missing PVC prime #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: The migration fails on cluster with 4.14 CNV CDI. The 4.14 CNV CDI does not use prime PVC but uses the DV id. Error: ``` persistentvolumeclaims prime-b9d0f99b-4e02-469e-83e2-74dbb186531b not found ``` Fix: Try to fetch the prime pvc but if it fails use the original name and ignore error. This way it will be backwards compatible and support the new prime PVC case. Ref: https://issues.redhat.com/browse/MTV-1693 Signed-off-by: Martin Necas <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
- Coverage 15.65% 15.65% -0.01%
==========================================
Files 112 112
Lines 23071 23075 +4
==========================================
Hits 3612 3612
- Misses 19174 19178 +4
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The migration fails on cluster with 4.14 CNV CDI. The 4.14 CNV CDI does not use prime PVC but uses the DV id.
Error:
Fix: Try to fetch the prime pvc but if it fails use the original name and ignore error. This way it will be backwards compatible and support the new prime PVC case.
Ref: https://issues.redhat.com/browse/MTV-1693