-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: switch to working virtio-win driver link #1205
Conversation
Signed-off-by: Artur Shad Nik <[email protected]>
Quality Gate passedIssues Measures |
Thanks for pointing this out that the virtio is still outdated in the built image. |
Issue: When running `make build-virt-v2v-image` the build failed due to some packages throwing 404. Fix: I needed to change the rpm url from AppStream to BaseOs for perl packages. It was not detected by the `./hack/virt-v2v-rpm-deps.sh` as the packages did not change (did not got updated) but only their location changed. Might be issue in the bazeldnf rpmtree. Fixes: kubev2v#1205 Signed-off-by: Martin Necas <[email protected]>
Posted #1214, once that gets merged it should help with the build and the image should get updated. TLDR bazel dnf issues. We are actively working on moving away from Bazel to Konflux with basic dockerfiles. |
Issue: When running `make build-virt-v2v-image` the build failed due to some packages throwing 404. Fix: I needed to change the rpm url from AppStream to BaseOs for perl packages. It was not detected by the `./hack/virt-v2v-rpm-deps.sh` as the packages did not change (did not got updated) but only their location changed. Might be issue in the bazeldnf rpmtree. Fixes: #1205 Signed-off-by: Martin Necas <[email protected]>
Got it, thanks! I noticed in the PR you linked, you're switching back to v1.9.15 - which is still problematic for Win22 migrations. Are there plans to move to a newer version of the driver as part of switching to Konflux? |
Ahh! Good eye! My fault, I'll post another with virtio-win-1.9.40-1.el9 |
Perfect, thank you 🙏 |
Merged, please let me know how it goes with win22 |
Following up on #1048 (comment), the virtio-win driver link currently used in the Bazel build does not seem to work.
quay.io/kubev2v/forklift-virt-v2v:latest
still contains the old 1.9.15 version. This is causing Windows 2022 VMs to boot to blue screen after migration.This PR swaps to a different, working, virtio-win package link. This is a fedora package, but it seems to be compatible with the CentOS image being used for virt-v2v. Tested with Win22, the machine successfully boots up and is usable.
This is hopefully a temporary solution while a working download for the CentOS package is being resolved.