Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to working virtio-win driver link #1205

Closed
wants to merge 1 commit into from

Conversation

arturshadnik
Copy link
Contributor

Following up on #1048 (comment), the virtio-win driver link currently used in the Bazel build does not seem to work. quay.io/kubev2v/forklift-virt-v2v:latest still contains the old 1.9.15 version. This is causing Windows 2022 VMs to boot to blue screen after migration.

This PR swaps to a different, working, virtio-win package link. This is a fedora package, but it seems to be compatible with the CentOS image being used for virt-v2v. Tested with Win22, the machine successfully boots up and is usable.

This is hopefully a temporary solution while a working download for the CentOS package is being resolved.

@mnecas
Copy link
Member

mnecas commented Nov 26, 2024

Thanks for pointing this out that the virtio is still outdated in the built image.
Sadly this won't help it, there is some problem with building of the images in GitHub actions.
Checking the issue

mnecas added a commit to mnecas/forklift that referenced this pull request Nov 26, 2024
Issue: When running `make build-virt-v2v-image` the build failed due to
some packages throwing 404.

Fix: I needed to change the rpm url from AppStream to BaseOs for perl
packages. It was not detected by the `./hack/virt-v2v-rpm-deps.sh` as
the packages did not change (did not got updated) but only their
location changed. Might be issue in the bazeldnf rpmtree.

Fixes: kubev2v#1205

Signed-off-by: Martin Necas <[email protected]>
@mnecas mnecas mentioned this pull request Nov 26, 2024
@mnecas
Copy link
Member

mnecas commented Nov 26, 2024

Posted #1214, once that gets merged it should help with the build and the image should get updated. TLDR bazel dnf issues. We are actively working on moving away from Bazel to Konflux with basic dockerfiles.

@mnecas mnecas closed this in #1214 Nov 26, 2024
mnecas added a commit that referenced this pull request Nov 26, 2024
Issue: When running `make build-virt-v2v-image` the build failed due to
some packages throwing 404.

Fix: I needed to change the rpm url from AppStream to BaseOs for perl
packages. It was not detected by the `./hack/virt-v2v-rpm-deps.sh` as
the packages did not change (did not got updated) but only their
location changed. Might be issue in the bazeldnf rpmtree.

Fixes: #1205

Signed-off-by: Martin Necas <[email protected]>
@arturshadnik arturshadnik deleted the fix/virtio-win branch November 26, 2024 21:04
@arturshadnik
Copy link
Contributor Author

Posted #1214, once that gets merged it should help with the build and the image should get updated. TLDR bazel dnf issues. We are actively working on moving away from Bazel to Konflux with basic dockerfiles.

Got it, thanks! I noticed in the PR you linked, you're switching back to v1.9.15 - which is still problematic for Win22 migrations. Are there plans to move to a newer version of the driver as part of switching to Konflux?

@mnecas
Copy link
Member

mnecas commented Nov 26, 2024

Ahh! Good eye! My fault, I'll post another with virtio-win-1.9.40-1.el9

@arturshadnik
Copy link
Contributor Author

Perfect, thank you 🙏

@mnecas
Copy link
Member

mnecas commented Nov 26, 2024

Merged, please let me know how it goes with win22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants