MTV-1458 | Make Guest information on vNICs is missing a warning #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
==========================================
+ Coverage 15.62% 15.66% +0.04%
==========================================
Files 112 112
Lines 23123 23130 +7
==========================================
+ Hits 3612 3623 +11
+ Misses 19226 19220 -6
- Partials 285 287 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yaacov
force-pushed
the
make-no-guest-information-warn
branch
4 times, most recently
from
8228437 to
fdd3566
Compare
yaacov
force-pushed
the
make-no-guest-information-warn
branch
from
fdd3566 to
fdad591
Compare
…s a warning instead of critical error Signed-off-by: yzamir <[email protected]>
yaacov
force-pushed
the
make-no-guest-information-warn
branch
from
fdad591 to
7d53bae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://issues.redhat.com/browse/MTV-1458
When selecting "preserve static IP" and migrating a VM without a static IP configuration, then the backend is reporting that the VM was not run. But thi sis incorrect, the VM was run, but it just does not have a static IP configuration (nt inside, and also not repoetred by the VMw API).
Issue:
Currently if a VM does not have static IP, and we set "preserve static IP" the plan is blocked,
Fix:
Changing the condition from "critical" to "warn" will unblock the plan, while still warning the user we may have an issue.