Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(KFLUXMIG-13): build mtv downstream bundle #1153

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ernesgonzalez33
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.57%. Comparing base (0d0b6cf) to head (a10bf19).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   15.57%   15.57%           
=======================================
  Files         112      112           
  Lines       23188    23188           
=======================================
  Hits         3612     3612           
  Misses      19291    19291           
  Partials      285      285           
Flag Coverage Δ
unittests 15.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernesgonzalez33
Copy link
Contributor Author

/retest

operator/export-vars.sh Outdated Show resolved Hide resolved
@ernesgonzalez33 ernesgonzalez33 marked this pull request as ready for review November 27, 2024 13:08
@ernesgonzalez33 ernesgonzalez33 marked this pull request as draft November 28, 2024 08:30
@ernesgonzalez33 ernesgonzalez33 force-pushed the build-bundle-downstream branch from 7adbcff to a10bf19 Compare December 8, 2024 13:55
Copy link

sonarcloud bot commented Dec 8, 2024

@ernesgonzalez33 ernesgonzalez33 marked this pull request as ready for review December 8, 2024 13:57
@ernesgonzalez33
Copy link
Contributor Author

@mnecas Code splitted, PTAL

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mnecas
Copy link
Member

mnecas commented Dec 9, 2024

Is it ready to get merged?

@ernesgonzalez33
Copy link
Contributor Author

@mnecas Yes

@mnecas mnecas merged commit 2ecf2a2 into kubev2v:main Dec 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants