Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1555 | Fix virt-v2v with new name #1084

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Oct 4, 2024

Issue:
The MTV specifies the -on argument in the wrong place /usr/bin/virt-v2v [...] -- epassaroMigrate-2 -on epassaromigrate-2

Fix:
/usr/bin/virt-v2v [...] -on newname -- oldname

Issue:
The MTV specifies the `-on` argument in the wrong place
/usr/bin/virt-v2v [...] -- epassaroMigrate-2 -on epassaromigrate-2

Fix:
/usr/bin/virt-v2v [...] -on newname -- oldname

Signed-off-by: Martin Necas <[email protected]>
@mnecas mnecas requested a review from yaacov as a code owner October 4, 2024 11:08
Copy link

sonarqubecloud bot commented Oct 4, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.32%. Comparing base (e3dbc9a) to head (bd1606b).

Files with missing lines Patch % Lines
virt-v2v/cmd/entrypoint.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   16.27%   16.32%   +0.04%     
==========================================
  Files         112      112              
  Lines       19785    19785              
==========================================
+ Hits         3220     3229       +9     
+ Misses      16280    16269      -11     
- Partials      285      287       +2     
Flag Coverage Δ
unittests 16.32% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwmjones
Copy link
Contributor

rwmjones commented Oct 4, 2024

Yes this is perfect, thanks.

@mnecas mnecas merged commit bf6adb0 into kubev2v:main Oct 7, 2024
24 of 34 checks passed
@mnecas mnecas mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants