From 8ebc20dee73ccbe344b8bc1d4cd83d7d117901ab Mon Sep 17 00:00:00 2001 From: Arik Hadas Date: Tue, 28 Nov 2023 11:33:39 +0200 Subject: [PATCH] Replace post-vendor.sh with a .gitignore rule It's hard to enforce developers to use `make vendor` so dropping the post-vendor.sh script that removed unused files that introduce warning by code analyze tools and we will use .gitignore rules instead. Signed-off-by: Arik Hadas --- .gitignore | 3 +++ Makefile | 1 - hack/post-vendor.sh | 4 ---- 3 files changed, 3 insertions(+), 5 deletions(-) delete mode 100755 hack/post-vendor.sh diff --git a/.gitignore b/.gitignore index 9d468b529..99352d7c4 100644 --- a/.gitignore +++ b/.gitignore @@ -37,3 +37,6 @@ bazel-* # deploy env hack/deploy/**/deploy.env + +# unused Dockerfiles +vendor/**/Dockerfile diff --git a/Makefile b/Makefile index bce659e30..3e7b856ea 100644 --- a/Makefile +++ b/Makefile @@ -143,7 +143,6 @@ tidy: # Run go mod vendor against code vendor: go mod vendor - ./hack/post-vendor.sh # Generate code generate: controller-gen diff --git a/hack/post-vendor.sh b/hack/post-vendor.sh deleted file mode 100755 index 68061649e..000000000 --- a/hack/post-vendor.sh +++ /dev/null @@ -1,4 +0,0 @@ -#!/usr/bin/env bash - -rm vendor/github.com/nxadm/tail/Dockerfile -rm vendor/github.com/pelletier/go-toml/v2/Dockerfile