Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom labels in CCM Helm chart #1021

Open
kwohlfahrt opened this issue Sep 9, 2024 · 2 comments
Open

Allow custom labels in CCM Helm chart #1021

kwohlfahrt opened this issue Sep 9, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@kwohlfahrt
Copy link

What would you like to be added:

Add custom labels to objects of the AWS CCM Helm chart.

Why is this needed:

We install the AWS CCM as a Helm chart. We also add labels to all infrastructure components (e.g. app.kubernetes.io/part-of: core-infrastructure), to make it easeir to distinguish them from user workloads and allocate cost appropariately.

Unfortunately, the AWS CCM Helm chart does not allow customizing object labels, like e.g. the cluster autoscaler does with additionalLabels, so we can't follow our usual pattern here.

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 9, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwohlfahrt
Copy link
Author

I'm happy to submit a PR adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants